Docker instructions #34
Conversation
|
@dbeatty10 can you link me to the PR for the change in core? and is it ok that we don't currently call out that this example only works for dbt-core>=1.3.0 |
Here is the PR that added this to Core 1.3.
On one handIt's probably okay since this is explicitly intended as a demo project rather than a project template. Following the readme instructions will automatically get dbt-core 1.3 because of this line. On the otherIf we don't mind the extra text, we could also call out this minimum version in the README somewhere. But the README already feels way too long to me currently -- I'd love to reduce the amount of text dramatically to something more like this. Optionally, we could further support a minimum version of 1.3.0 via require-dbt-version |
|
@dbeatty10 Happy to review a PR if you revamp the README for conciseness and cleaner formatting! |
Thank you @sungchun12 -- created an issue here, and I'll request you as a reviewer if/when I take a swing at a revamp 👍 |
ok got it! I was hoping this would show up in the docs, but perhaps addressing dbt-labs/docs.getdbt.com#2024 is part of the official 1.3 release milestone? |
🎯 |
Resolves #33
Overview
profiles.ymlviaDBT_PROFILES_DIRno longer neededprofiles.ymlviaDBT_PROFILES_DIRAs of dbt Core 1.3, setting the
DBT_PROFILES_DIRenvironment variable is no longer necessary:jaffle_shop_duckdb/Dockerfile
Line 14 in 8574cf7
Documentation
Also, made some slight updates to the instructions for running Docker with VSCode locally.
Validation
These changes can be validated by:
dbt debugand noting that it is looking for profiles in the intended directory (and connecting successfully)dbt build